Retry allocation with fallback flags #2451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@0cc4m What do you think about this patch? Should we merge it upstream? |
|
@ggerganov Yeah, this should go upstream. I haven't tested it yet, but it looks good. It might even fix ggerganov/llama.cpp#9734. |
4 tasks
ggerganov
approved these changes
Oct 6, 2024
There was a problem hiding this comment.
I just tested it and it also fixes the issue reported in #2411 (comment)
bygreencn
added a commit
to bygreencn/whisper.cpp
that referenced
this pull request
Oct 12, 2024
# By Georgi Gerganov (18) and others # Via Georgi Gerganov * tag 'v1.7.1': (43 commits) release : v1.7.1 vulkan : retry allocation with fallback flags (ggerganov#2451) release : v1.7.0 scripts : bench v3-turbo whisper : remove mel leftover constants (396089f) whisper : zero-out the KV cache upon clear (ggerganov#2445) objc : fix build metal : zero-init buffer contexts (#0) whisper : revert mel-related changes (#0) whisper : adapt to latest ggml (skip) (#0) ggml : fix typo in example usage ggml_gallocr_new (ggml/984) ggml : fixes after sync (ggml/983) ggml-backend : add device and backend reg interfaces (llama/9707) Fixed dequant precision issues in Q4_1 and Q5_1 (llama/9711) ggml-backend : add device and backend reg interfaces (llama/9707) Initial cmake support of SYCL for AMD GPUs (llama/9658) vulkan : do not use tensor->extra (llama/9407) ggml/ex: calculate accuracy in graph, adapt MNIST (ggml/980) ggml: refactor cross entropy loss CPU impl. (ggml/976) scripts : sync ggml-backend.cpp ... # Conflicts: # bindings/javascript/package.json
lyapple2008
pushed a commit
to lyapple2008/whisper.cpp.mars
that referenced
this pull request
Nov 2, 2024
Co-authored-by: Samuel Morris <samuel.morris@artlist.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #2450
I'm unsure what the exact cause is as I'm not overly familiar with Vulkan. So feel free to reject if you can think of a better solution.