Add cuBLAS build workflow and fix error causing lines in CMakeLists #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Green-Sky
suggested changes
May 3, 2023
| - name: Build | ||
| run: | | ||
| cd ./build | ||
| msbuild ALL_BUILD.vcxproj -t:build -p:configuration=${{ matrix.build }} -p:platform=${{ matrix.arch }} |
There was a problem hiding this comment.
prefer the use of cmake --build
There was a problem hiding this comment.
Could you explain why this is better than the current one? I'm not really that well-versed in CMake or compiling C++ projects in general so I just used the same as the other Windows builds.
There was a problem hiding this comment.
It makes it buildsystem agnostic. In theory we could switch to eg. Ninja, without touching that line.
Consider it best practice.
There was a problem hiding this comment.
Hmm, wouldn't it be best to switch all the builds to that all at once?
There was a problem hiding this comment.
Sure, we can do that in a follow up PR
|
xref llama.cpp ggerganov/llama.cpp#1271 |
ggerganov
approved these changes
May 3, 2023
jacobwu-b
pushed a commit
to jacobwu-b/Transcriptify-by-whisper.cpp
that referenced
this pull request
Oct 24, 2023
…sts (ggerganov#867) * Add windows build with cuBLAS * Remove error causing lines for cuBLAS on Windows
jacobwu-b
pushed a commit
to jacobwu-b/Transcriptify-by-whisper.cpp
that referenced
this pull request
Oct 24, 2023
…sts (ggerganov#867) * Add windows build with cuBLAS * Remove error causing lines for cuBLAS on Windows
landtanin
pushed a commit
to landtanin/whisper.cpp
that referenced
this pull request
Dec 16, 2023
…sts (ggerganov#867) * Add windows build with cuBLAS * Remove error causing lines for cuBLAS on Windows
iThalay
pushed a commit
to iThalay/whisper.cpp
that referenced
this pull request
Sep 23, 2024
…sts (ggerganov#867) * Add windows build with cuBLAS * Remove error causing lines for cuBLAS on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a build workflow for whisper.cpp on Windows with cuBLAS support. Removes error causing lines in CMakeLists that prevented building successfully.
Credit: @giterhug for the fix.
#840