Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix define used for COREML_ALLOW_FALLBACK #893

Merged
merged 1 commit into from
May 8, 2023

Conversation

jcsoo
Copy link
Contributor

@jcsoo jcsoo commented May 8, 2023

CMakeLists.txt defines WHISPER_USE_COREML_ALLOW_FALLBACK when COREML_ALLOW_FALLBACK=1 is used:

        if (WHISPER_COREML_ALLOW_FALLBACK)
            set(WHISPER_EXTRA_FLAGS ${WHISPER_EXTRA_FLAGS} -DWHISPER_USE_COREML_ALLOW_FALLBACK)
        endif()

But whisper.cpp actually uses WHISPER_COREML_ALLOW_FALLBACK:

#ifndef WHISPER_COREML_ALLOW_FALLBACK
        return nullptr;
#endif

@ggerganov ggerganov merged commit bf2449d into ggerganov:master May 8, 2023
jacobwu-b pushed a commit to jacobwu-b/Transcriptify-by-whisper.cpp that referenced this pull request Oct 24, 2023
jacobwu-b pushed a commit to jacobwu-b/Transcriptify-by-whisper.cpp that referenced this pull request Oct 24, 2023
landtanin pushed a commit to landtanin/whisper.cpp that referenced this pull request Dec 16, 2023
iThalay pushed a commit to iThalay/whisper.cpp that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants