Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

java bindings #931

Merged
merged 6 commits into from
May 20, 2023
Merged

java bindings #931

merged 6 commits into from
May 20, 2023

Conversation

nalbion
Copy link
Collaborator

@nalbion nalbion commented May 16, 2023 •
edited
Loading

@ggerganov I've tested fullTranscribe() and getTextSegment() on Windows and Ubuntu.

git clone https://github.com/nalbion/whisper.cpp.git
cd whisper.cpp/bindings/java
git checkout feature/java-bindings

mkdir build
pushd build
cmake ..
cmake --build .
popd

./gradlew test

And so my fellow Americans, ask not what your country can do for you, ask what you can do for your country.

@ggerganov ggerganov merged commit bc89f28 into ggerganov:master May 20, 2023
@nalbion
Copy link
Collaborator Author

nalbion commented May 20, 2023

@ggerganov can you update the github workshops to build and publish to maven central please?

@nalbion
Copy link
Collaborator Author

nalbion commented May 20, 2023

...it should build the libs for Mac, Linux and Windows and then run the gradle build which will emebed the libs into the jar

@ggerganov
Copy link
Owner

Won't have time to do that anytime soon - I would gladly accept a PR with this change

@nalbion
Copy link
Collaborator Author

nalbion commented May 21, 2023

It was easier to fix my implementation 😅

#944

jacobwu-b pushed a commit to jacobwu-b/Transcriptify-by-whisper.cpp that referenced this pull request Oct 24, 2023
@nalbion
bindings : add java bindings (ggerganov#931)
47ea733 
* WIP - java bindings

* updated README

* failed attempt at JNI

* fullTranscribe() test passes

* tested on Ubuntu 20

* link to Java bindings
jacobwu-b pushed a commit to jacobwu-b/Transcriptify-by-whisper.cpp that referenced this pull request Oct 24, 2023
@nalbion
bindings : add java bindings (ggerganov#931)
76b5fa0 
* WIP - java bindings

* updated README

* failed attempt at JNI

* fullTranscribe() test passes

* tested on Ubuntu 20

* link to Java bindings
landtanin pushed a commit to landtanin/whisper.cpp that referenced this pull request Dec 16, 2023
@nalbion
bindings : add java bindings (ggerganov#931)
f75ff15 
* WIP - java bindings

* updated README

* failed attempt at JNI

* fullTranscribe() test passes

* tested on Ubuntu 20

* link to Java bindings
iThalay pushed a commit to iThalay/whisper.cpp that referenced this pull request Sep 23, 2024
@nalbion @iThalay
bindings : add java bindings (ggerganov#931)
1c9f046 
* WIP - java bindings

* updated README

* failed attempt at JNI

* fullTranscribe() test passes

* tested on Ubuntu 20

* link to Java bindings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nalbion @ggerganov