Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: use slash as name/version separator #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Oct 15, 2017

this avoids weird ambiguity "XML-RPC for PHP 4.2.1" sounds like it's for PHP version in question, not this library.

personally i would change whole agent to be project name "PHPXMLRPC/4.2.1" or "phpxmlrpc/4.2.1", but that might break some scenarios when useragent is matched on remote side.

this avoids weird ambiguity "XML-RPC for PHP 4.2.1" sounds like it's for PHP 4.2.1
@gggeek
Copy link
Owner

gggeek commented Oct 28, 2017

As you noted, this might break cases where users were crazy enough to depend on that string.
As I am a great fan of keeping BC in general, and esp. for this one library, I will only include this change in the next major version of the lib (which is currently not scheduled, sorry).

@glensc
Copy link
Contributor Author

glensc commented May 26, 2019

perhaps keep the current string, and additionally add the new one "phpxmlrpc/4.2.1" for now? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants