ggml : add support for multiple ids rows in ggml_mat_mul_id #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaren
changed the title
ggerganov
approved these changes
Dec 9, 2023
| [encoder setBuffer:id_src0 offset:offs_src0 atIndex:0]; | ||
| [encoder setBuffer:id_src1 offset:offs_src1 atIndex:1]; | ||
| [encoder setBuffer:id_dst offset:offs_dst atIndex:2]; | ||
| const int64_t _ne1 = 1; // kernel_mul_mm_impl needs a reference in constant memory |
There was a problem hiding this comment.
I will figure out this later - likely there will be additional changes to this OP to make it support mat-vec as well
|
The changes in this PR have been integrated in ggml-org/llama.cpp#4406 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.