Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commit 96ea727 breaks compilation in Windows #74

Closed
etra0 opened this issue Mar 13, 2023 · 3 comments
Closed

commit 96ea727 breaks compilation in Windows #74

etra0 opened this issue Mar 13, 2023 · 3 comments
Labels
bug Something isn't working build Compilation issues

Comments

@etra0
Copy link
Contributor

etra0 commented Mar 13, 2023

Sadly, Windows terminal support of ANSI colors and signals is simply... non-existent, and this PR in particular adds a ton of things that are not supported by this OS.

I don't know if filling the entire llama.cpp with #ifdefs would be ideal... or to rewrite those changes to encapsulate them better to make it less painful, but either way, it is a lot of work.

Reverting that commit and doing a couple of merge fixes makes it work.

PS: Maybe it would be good to add an action that compiles the software in the three platforms? but, yet, I'm curious about the willing to support windows as well since it's the special kid between the unix-like guys :)
@etra0 etra0 changed the title 96ea727f4780620b60c1897b538654931411a3fd breaks compilation in Windows commit https://github.com/ggerganov/llama.cpp/commit/96ea727f4780620b60c1897b538654931411a3fd breaks compilation in Windows Mar 13, 2023
@etra0 etra0 changed the title commit https://github.com/ggerganov/llama.cpp/commit/96ea727f4780620b60c1897b538654931411a3fd breaks compilation in Windows commit 96ea727 breaks compilation in Windows Mar 13, 2023
@etra0 etra0 mentioned this issue Mar 13, 2023
Merged
@etra0 etra0 changed the title commit 96ea727 breaks compilation in Windows commit [96ea727](https://github.com/ggerganov/llama.cpp/commit/96ea727f4780620b60c1897b538654931411a3fd) breaks compilation in Windows Mar 13, 2023
@etra0 etra0 changed the title commit [96ea727](https://github.com/ggerganov/llama.cpp/commit/96ea727f4780620b60c1897b538654931411a3fd) breaks compilation in Windows commit 96ea727 breaks compilation in Windows Mar 13, 2023
@etra0
Copy link
Contributor Author

etra0 commented Mar 13, 2023

Oh my god, I'm sorry for all the edits, I thought links on the titles were supported, lol

blackhole89 added a commit that referenced this issue Mar 13, 2023
@blackhole89
Gate signal support on being on a unixoid system. (#74)
a169bb8
@blackhole89
Copy link
Contributor

I #if-gated the signals-related stuff (which I figure would not work on Windows). As for ANSI colors, I figure you can always just not pass --color. Did that fix the build?

@etra0
Copy link
Contributor Author

etra0 commented Mar 13, 2023

I confirm that the commit a169bb8 fixes this issue!

@etra0 etra0 closed this as completed Mar 13, 2023
@gjmulder gjmulder added bug Something isn't working build Compilation issues labels Mar 15, 2023
@vikrantrathore vikrantrathore mentioned this issue Apr 1, 2023
Closed
2 tasks
@Bearsaerker Bearsaerker mentioned this issue Mar 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working build Compilation issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@blackhole89 @gjmulder @etra0