-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-thread ggml_cpy() #782
Comments
Hi, this is my first contribution to a large project so forgive me for being a newbie! I attempted to multithread cpy following the code from the rope commit but I started getting garbage output given an initial prompt. Would appreciate any guidance on what I'm doing wrong! Fs77X@3c8a304 |
So I have updated While at it, I tried to multi-thread it and didn't observed any measurable improvements, so I guess there is no point in multi-threading it. I will close this issue now |
@ggerganov Do you still have your multi-threaded implementation of |
No, but it was pretty much the same as: https://github.com/ggerganov/llama.cpp/pull/824/files const int ith = params->ith;
const int nth = params->nth;
int ir = 0; |
@ggerganov Hello, Does [ggml profiler (GGML_PERF)] not support now? |
This is a task suitable for new contributors
See how we multi-threaded the ggml_rope() operator.
Do the same for the
ggml_cpy()
operator and see if there is any benefit.Use the ggml profiler (GGML_PERF) to measure the benefit of multi-threaded vs non-multi-threaded
ggml_cpy()
The text was updated successfully, but these errors were encountered: