Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print timings on ctrl+c exit #1021

Merged
merged 3 commits into from
Apr 22, 2023
Merged

print timings on ctrl+c exit #1021

merged 3 commits into from
Apr 22, 2023

Conversation

wbpxre150
Copy link
Contributor

Currently the timing stats do not print when you use CTRL+C to exit interactive mode. This is the simplest way to fix that.

ggerganov
ggerganov requested changes Apr 21, 2023
View reviewed changes
Copy link
Member

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestions are pretty minor, but I just want to keep ctx a local variable.
So I add a global pointer to observe it

@wbpxre150
Copy link
Contributor Author

@ggerganov
I have committed these changes, all works as expected, thanks for the suggestion. Don't know why I didn't think of this myself. :)

@ggerganov ggerganov merged commit 36b4f7e into ggml-org:master Apr 22, 2023
Deadsg pushed a commit to Deadsg/llama.cpp that referenced this pull request Dec 19, 2023
@kddubey
perf: Don't convert logprobs arrays to lists (ggml-org#1021)
6b2e0e0
@Bearsaerker Bearsaerker mentioned this pull request Mar 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DannyDaemonic DannyDaemonic DannyDaemonic left review comments

@ggerganov ggerganov ggerganov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wbpxre150 @ggerganov @DannyDaemonic