gguf-py: fixed local detection of gguf package #11180
Merged
+13
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LostRuins You mentioned that there were 8 files where this change needed to be made. I only found 5 of them. The impact was only on the files in the scripts directory from what I can tell. Can you point me to where the other files are? |
VJHack
changed the title
VJHack
changed the title
compilade
approved these changes
Jan 10, 2025
|
Yeah only the scripts folder should be affected, sorry. I just estimated based on a quick code search
|
LostRuins
approved these changes
Jan 11, 2025
tinglou
pushed a commit
to tinglou/llama.cpp
that referenced
this pull request
Feb 13, 2025
* updated path to gguf package for non-installed setups * added reader.py to readme * Bumped gguf version to 0.15.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The local detection of gguf python package was broken after #11116 in all python files inside
gguf-py/gguf/scriptsafter it had been moved. This impacted users if they didn't have gguf installed from PyPI.The fix updated the relative path to gguf-py and the root level gguf package.