cmake : add install step for libllama and llama.h #1124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps dependent CMake projects find the lib and header when they pull in llama.cpp with ExternalProject_Add().
|
FetchContent is cleaner than ExternalProject_Add() and works without this PR. Closing this as unnecessary. It might still be a good idea to have an install step, but there's probably more considerations than just putting a lib & header in system dirs. For example, the Nix flake doesn't seem to install either! No need to force the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps dependent CMake projects find the lib and header when they pull in llama.cpp with ExternalProject_Add().