-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example readme and some light refactoring #1131
Conversation
Thanks for putting in the work of writing docs, which many devs don't like to do ;-) I think Alternatively, have |
We might also want to shorten the top-level readme a bit, if there's duplicate information now. We can add a link to examples/main/README.md instead. |
This is unfortunate. I was working on this myself. Mine is at #1139. This is actually pretty decent. I noticed some spelling errors. |
but does this actually fist interactive-first? i realized it was broken recently |
It seems to work for me, at least to the extent where it stops after the first prompt, even if it does not end in a reverse prompt. Is there anything specific where it does not work? |
I have merged a few details to the new README that I think might be worth keeping (as it took me a while to figure them out). If this gets too detailed, I am fine with taking them out again. In addition, I added a link from the top-level README to increase visibility a bit. |
I have tried to take a first stab at writing a brief README for main.exe ( #518).
While trying to untangle the
--instruct
and--interactive
behaviour, I noticed a small inconsistency in the naming of internal parameters: There isparams.interactive_start
, while the command line parameter is called--interactive_first
, and there is also an--interactive_start
that, confusingly, does the same as--interactive
.So, I added a small refactoring change to rename the structure member for consistency.
Feedback is very welcome. If this looks reasonable, I can also try the same at least for perplexity and embeddings.