Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(LoRA): debugging #1190

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix(LoRA): debugging #1190

wants to merge 4 commits into from

Conversation

jon-chuang
Copy link
Contributor

@jon-chuang jon-chuang changed the title fix(minor): debugging LoRA fix(LoRA): debugging Apr 26, 2023
@jon-chuang
Copy link
Contributor Author

cc: @slaren

@slaren
Copy link
Member

slaren commented Apr 26, 2023

I don't think this is right. Try it with a LoRA that modifies non-square matrices such as baize. Your link seems to be about AdaLoRA which is a different technique.

@jon-chuang
Copy link
Contributor Author

jon-chuang commented Apr 26, 2023 •
edited
Loading

oops, got the print stmt right but the check ought to be the same as before

@Bearsaerker Bearsaerker mentioned this pull request Mar 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jon-chuang @slaren