-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] MUSA: enable fastfp16, correct warp reduce impl and perf tuning #12383
base: master
Are you sure you want to change the base?
Conversation
The auto-label system is bugged, accidentally tagging everything with "Nvidia GPU." |
how to requested a review from a specified expert in a specified PR? thanks so much! |
I can review the code in terms of the effects for the CUDA backend but I don't know anything about MUSA and do not have any MT hardware so I would need someone else to review this PR in terms of whether the changes are correct for MUSA. |
Same here but for effects on the hip backed. One thing code style wise i can say is that this pr currently contains alot of stuff that dose not belong like commented out logging printfs an the like. Otherwise it looks reasonable but i have no way of verifying correctness for MUSA |
Hi, thanks for the comments here. Sorry if it contains lots of debug prints now, which will be cleared when the perf tuning is done ;D |
Make sure to read the contributing guidelines before submitting a PR
[WIP] This PR will: