-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci : add cublas to windows release #1271
Conversation
If GitHub can handle the big releases, it is probably better to distribute the DLLs than to ask users to install the CUDA toolkit. Maybe also include an additional artifact that doesn't include the DLLs so that people who already have them don't need to download them again? |
sounds good |
eb69d98
to
44286d3
Compare
performing a manual release here https://github.com/ggerganov/llama.cpp/actions/runs/4875560144 edit: good i tested this, i forgot a depends |
@slaren can you try the ci binaries here https://github.com/ggerganov/llama.cpp/releases/tag/ci_cublas-45d94c8 ? |
Looks like no one is running a cuda 12 capable driver 🤣 , gonna add 11.7 |
These binaries work well for me! No issues. |
@slaren can you try the 11.7 binaries too? https://github.com/ggerganov/llama.cpp/releases/tag/ci_cublas-31ff9e2 |
Also works, but as expected I need to download the DLLs as well, as my CUDA toolkit is 12.1. The 12.1 binaries work without the DLL. |
IMO it is fine as is, but we could consider running the CI tests for cuBLAS only when ggml-cuda.h/cu have been modified. However, that may not achieve much beyond testing that the builds completes until we have a model small enough to use in CI tests. |
afaik we cant run cuda at all in the ci. 🙂 |
Yeah of course, I don't know what I was thinking. Checking that the build completes on Windows can still be useful, usually I do my testing under Linux/WSL2. It may also help find issues with the CUDA 11.7 build. |
My plan was to do the linux side next and provide ubuntu focal based binaries. :) |
let's see if someone complains, doing linux next. |
should have done linux first, it's an order of magnitude faster... |
This adds a cuBLAS build to the windows ci.
edit: did a test release, please test https://github.com/ggerganov/llama.cpp/releases/tag/ci_cublas-31ff9e2
Open questions:
the cuda dll's are huge, should we ship them? they also don't change (often)do we need the blasLt dll? ironically named "lite", it's the largest dll (>400mb)which cuda version to use. I set it to 12.1, but that requires the very latest driver.eula allowing redist https://docs.nvidia.com/cuda/eula/index.html#attachment-a