-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #1224 reverse prompt and multi line #1297
Conversation
works great for me :) |
Tested with a wider set of models and found 1 more bug in another part of the code. If the antiprompt is "User: ", and the model generated the tokens "User", ":", " How", then the program takes the last n characters, where n is the length of the antiprompt, and it turns out that it compares "User: " and "r: How" and does the conclusion that the antiprompt was not met. |
The fix for this issue is not very trivial. To resolve this, we introduced the |
Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
@ggerganov |
* fix reverse prompt and multi line * Code Formatting Co-authored-by: Georgi Gerganov <ggerganov@gmail.com> --------- Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
Unfortunately, I discovered that not only did this not fix the problem, it made it a whole lot worse. Previously, I was able to at least get it to produce more tokens by pressing enter. Now even that won't work. |
Fixes #1224
In the original code, when an empty line is encountered, it stops the user from entering, although in reality, an empty line can be a side effect of the previous input and should simply be ignored.