Skip to content

quantize: Handle user-defined pruning of whole layers (blocks) #13037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jun 22, 2025

Conversation

EAddario
Copy link
Contributor

@EAddario EAddario commented Apr 20, 2025

This PR adds the ability to prune all tensors from user-defined layers (blocks) by providing a comma-separated list in the --prune-layers command line option. It will renumber remaining layers to avoid gaps in the sequence, update the relevant model metadata and, if an imatrix is available, it will use the correct importance score vector.

Pruning is restricted to repeating layers only (i.e. blk.n, blk.n+1, etc.) and will not affect single tensors like output, token_embd, etc.

This option can be used alongside --tensor-type to perform tensor/layer-wise quantization on selected tensor types, whilst at the same time pruning others. For example:

llama-quantize --tensor-type attn=q6_k --prune-layers 3,7,11 --imatrix imatrix.dat model-f32.gguf model-q4_k_m.gguf q4_k_m

It was inspired partly by ShortGPT: Layers in Large Language Models are More Redundant Than You Expect and partly as the next logical step from #12511. It could be used alongside #12718 to guide the layer selection.

Opening a draft PR for now until split tensor testing is completed, but feedback and suggestions are encouraged in the meantime.

@EAddario EAddario marked this pull request as draft April 20, 2025 21:47
@EAddario EAddario marked this pull request as ready for review June 14, 2025 12:56
@EAddario
Copy link
Contributor Author

EAddario commented Jun 14, 2025

Finally finished testing several combinations with split files and it seems to work 100%

Examples of pruned models here and here

@EAddario
Copy link
Contributor Author

Apologies for shotgun approach @slaren / @CISC / @ggerganov, not sure what the proper process to request a review is. Happy to close or move to draft if it's not suitable for merging

@EAddario
Copy link
Contributor Author

Thank you @CISC!

Copy link
Collaborator

@CISC CISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits :)

EAddario and others added 2 commits June 22, 2025 13:08
Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
@EAddario
Copy link
Contributor Author

@CISC, much appreciated for spending time on this. Fixed the issues and ran different combinations of tests (split files in -> single out; single file in -> split out; split in -> split out; single in -> single out) pruning different layers (first, last, mix, non-existent, etc). Code is much more robust thanks to your feedback.

🤞

@CISC CISC merged commit fa4a9f2 into ggml-org:master Jun 22, 2025
47 checks passed
@EAddario EAddario deleted the prune branch June 23, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants