-
Notifications
You must be signed in to change notification settings - Fork 12.2k
quantize: Handle user-defined pruning of whole layers (blocks) #13037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Apologies for shotgun approach @slaren / @CISC / @ggerganov, not sure what the proper process to request a review is. Happy to close or move to draft if it's not suitable for merging |
Thank you @CISC! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits :)
credit to CISC for identifying bug and suggesting solution
@CISC, much appreciated for spending time on this. Fixed the issues and ran different combinations of tests (split files in -> single out; single file in -> split out; split in -> split out; single in -> single out) pruning different layers (first, last, mix, non-existent, etc). Code is much more robust thanks to your feedback. 🤞 |
This PR adds the ability to prune all tensors from user-defined layers (blocks) by providing a comma-separated list in the
--prune-layers
command line option. It will renumber remaining layers to avoid gaps in the sequence, update the relevant model metadata and, if an imatrix is available, it will use the correct importance score vector.Pruning is restricted to repeating layers only (i.e. blk.n, blk.n+1, etc.) and will not affect single tensors like output, token_embd, etc.
This option can be used alongside
--tensor-type
to perform tensor/layer-wise quantization on selected tensor types, whilst at the same time pruning others. For example:llama-quantize --tensor-type attn=q6_k --prune-layers 3,7,11 --imatrix imatrix.dat model-f32.gguf model-q4_k_m.gguf q4_k_m
It was inspired partly by ShortGPT: Layers in Large Language Models are More Redundant Than You Expect and partly as the next logical step from #12511. It could be used alongside #12718 to guide the layer selection.
Opening a draft PR for now until split tensor testing is completed, but feedback and suggestions are encouraged in the meantime.