Skip to content

gguf/utility: return full content on size < 0 #13841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2025
Merged

gguf/utility: return full content on size < 0 #13841

merged 2 commits into from
May 28, 2025

Conversation

Beinsezii
Copy link
Contributor

response.content[:-1] truncates the last byte which can break model_index.json reading for --remote converts

@github-actions github-actions bot added the python python script changes label May 28, 2025
CISC
CISC requested changes May 28, 2025
View reviewed changes
Copy link
Collaborator

@CISC CISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funky, surprised it didn't fail frequently. :)

@Beinsezii @CISC
Update gguf-py/gguf/utility.py
05e23d1 
Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
@Beinsezii
Copy link
Contributor Author

Funky, surprised it didn't fail frequently. :)

Trailing newlines pulling a lot of work maybe lol. I noticed it errs particularly with mergekit models. Their json dump must not have any fluff.

@CISC CISC merged commit 53ae306 into ggml-org:master May 28, 2025
4 checks passed
@Beinsezii Beinsezii deleted the beinsezii/remote_hf_trunc_fix branch May 28, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CISC CISC CISC approved these changes

Assignees
No one assigned
Labels
python python script changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Beinsezii @CISC