Fix crlf quantize #143
Closed
Fix crlf quantize #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you sure it's not on your end? You seem to be using MSYS git yourself, which translates to CRLF automatically. I checked my copy with a hex editor and it's fine, CR-free. |
|
@Ronsor would be quite weird, as I'm on Arch, but let me check. |
|
But yeah, you're right, it does seem to happen from my end somehow, the Curl-downloaded script is fine |
ghost
closed this
ghost
deleted the
Deadsg
pushed a commit
to Deadsg/llama.cpp
that referenced
this pull request
Dec 19, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The quantize.sh script has CRLF line ending which means it can't be run on an actual Linux system (probably the author uses MSYS2?) - see https://unix.stackexchange.com/questions/577663/handling-bash-script-with-crlf-carriage-return-in-linux-as-in-msys2
Wait, let me actually test if this PR works or not, Git is really weird with those line endings