Skip to content

nix: use optionalAttrs for env mkDerivation attrset argument #14726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2025
Merged

nix: use optionalAttrs for env mkDerivation attrset argument #14726

merged 1 commit into from
Jul 17, 2025

Conversation

amozeo
Copy link
Contributor

@amozeo amozeo commented Jul 16, 2025 •
edited
Loading

Fixes nix eval of packages.${system}.default with newer nixpkgs revision.

Previously eval failed with:

    error: expected a set but found a list: [ ]

lib.optionals is not for attrsets, lib.optionalAttrs is instead.

@github-actions github-actions bot added nix Issues specific to consuming flake.nix, or generally concerned with ❄ Nix-based llama.cpp deployment devops improvements to build systems and github actions labels Jul 16, 2025
@amozeo amozeo changed the title nix: use overrideAttrs for env mkDerivation attrset argument nix: use optionalAttrs for env mkDerivation attrset argument Jul 16, 2025
@langsjo
Copy link

langsjo commented Jul 17, 2025

@philiptaron

@philiptaron philiptaron merged commit 760b448 into ggml-org:master Jul 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@philiptaron philiptaron philiptaron approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

devops improvements to build systems and github actions nix Issues specific to consuming flake.nix, or generally concerned with ❄ Nix-based llama.cpp deployment

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amozeo @langsjo @philiptaron