fix some unicode prob #1584
fix some unicode prob #1584
Conversation
|
ignore build.yml it just for test some item |
| @@ -522,6 +522,11 @@ void console_init(console_state & con_st) { | |||
| // Turn off ICANON (ENABLE_LINE_INPUT) and ECHO (ENABLE_ECHO_INPUT) | |||
| dwMode &= ~(ENABLE_LINE_INPUT | ENABLE_ECHO_INPUT); | |||
| SetConsoleMode(hConIn, dwMode); | |||
| }else{ | |||
| // Set console input codepage to UTF8 | |||
| _setmode(_fileno(stdin), _O_U8TEXT); | |||
There was a problem hiding this comment.
Is this necessary when your configured locale has "UTF-8" in it?
| // Set console input codepage to UTF8 | ||
| _setmode(_fileno(stdin), _O_U8TEXT); | ||
| // Set locale to Chinese Simplified UTF-8 | ||
| setlocale(LC_ALL, "zh-CN.UTF-8"); |
There was a problem hiding this comment.
This sets everyone to Chinese. When someone doesn't have "zh_CN.UTF-8" installed on their system, it will instead set to "C", which breaks Unicode support for them.
What we already have:
setlocale(LC_ALL, "");
When setlocale is used with an empty string, it uses your system locale settings. In Linux you can set it like this:
export LANG=zh_CN.UTF-8See this post at Stack Overflow for more information.
|
i am use windows 10 os maybe this pr is not good for here |
make it support chinese more