Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: "inline" -> "static inline" for bytesFromNibbles and packNibbles #161

Merged
merged 1 commit into from
Mar 15, 2023
Merged

FIX: "inline" -> "static inline" for bytesFromNibbles and packNibbles #161

merged 1 commit into from
Mar 15, 2023

Conversation

hoangmit
Copy link
Contributor

@hoangmit hoangmit commented Mar 15, 2023 •
edited
Loading

Without the "static" quantifier, it fails to compile in clang:

ld.lld: error: undefined symbol: packNibbles
>>> referenced by ggml.c:520 (llama_cpp/ggml.c:520)
>>>               .../llama_cpp/__ggml__/__objects__/ggml.c.pic.o:(quantize_row_q4_0)

ld.lld: error: undefined symbol: bytesFromNibbles
>>> referenced by ggml.c:1434 (llama_cpp/ggml.c:1434)
>>>               .../llama_cpp/__ggml__/__objects__/ggml.c.pic.o:(ggml_vec_dot_q4_0)
>>> referenced by ggml.c:1435 (llama_cpp/ggml.c:1435)
>>>               .../llama_cpp/__ggml__/__objects__/ggml.c.pic.o:(ggml_vec_dot_q4_0)
clang-12: error: linker command failed with exit code 1 (use -v to see invocation)

@hoangmit
inline -> static inline for "bytesFromNibbles"
405d94e 
Without "static" prefix, it fails to compile in clang
@hoangmit hoangmit changed the title inline -> static inline for "bytesFromNibbles" "inline" -> "static inline" for "bytesFromNibbles" Mar 15, 2023
@hoangmit hoangmit changed the title "inline" -> "static inline" for "bytesFromNibbles" "inline" -> "static inline" for bytesFromNibbles and packNibbles Mar 15, 2023
@hoangmit hoangmit changed the title "inline" -> "static inline" for bytesFromNibbles and packNibbles FIX: "inline" -> "static inline" for bytesFromNibbles and packNibbles Mar 15, 2023
@ggerganov ggerganov merged commit 113e685 into ggml-org:master Mar 15, 2023
@setzer22 setzer22 mentioned this pull request Mar 15, 2023
Closed
6 tasks
blackhole89 pushed a commit that referenced this pull request Mar 15, 2023
@hoangmit @blackhole89
inline -> static inline for "bytesFromNibbles" (#161)
aaf0b51 
Without "static" prefix, it fails to compile in clang
bitRAKE pushed a commit to bitRAKE/llama.cpp that referenced this pull request Mar 17, 2023
@hoangmit @bitRAKE
inline -> static inline for "bytesFromNibbles" (ggml-org#161)
6a962bd 
Without "static" prefix, it fails to compile in clang
Deadsg pushed a commit to Deadsg/llama.cpp that referenced this pull request Dec 19, 2023
@abetlen
Merge pull request ggml-org#161 from abetlen/dependabot/pip/pytest-7.3.1
8a692a5 
Bump pytest from 7.2.2 to 7.3.1
@Bearsaerker Bearsaerker mentioned this pull request Mar 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoangmit @ggerganov