-
Notifications
You must be signed in to change notification settings - Fork 13.3k
ci : enable Vulkan workflow on Mac #16194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but no idea what's going on here:
https://github.com/ggml-org/llama.cpp/actions/runs/17938949707/job/51010682770?pr=16194#step:3:4196
I'm not sure either. @0cc4m Let me know if you are interested in adding MoltenVK workflow to the CI. Atm, it seems to require some fixes in the IM2COL and CONV kernels to be able to run correctly. Feel free to push into this branch if you find a fix. |
Do people have hope KosmicKrisp will be even better than MoltenVK? Tagging @kpouget here, I think he built this on macOS before. |
@ggerganov we reported that problem to MoltenVK and it was fixed in 1.4. Are you sure the MVK version is up to date? |
I have a nightly performance testing running everyday, and it builds correctly the Vulkan version
hum but I see now that it's the |
@0cc4m The runner is using the v1.4.321.0 SDK from this site: https://vulkan.lunarg.com/sdk/home. I think this is the latest version.
|
I'm using a homebrew version and it's just fine. Seems to be 2 minor versions further, though:
With that, it passes test-backend-ops fully. |
Actually no, your version is far behind:
That is the problem. |
Thanks, that fixed it. |
* origin/master: (39 commits) ci : disable AMD workflows + update NVIDIA workflows (ggml-org#16200) ci : enable Vulkan workflow on Mac (ggml-org#16194) ggml-cpu: Respect cpumask settings (ggml-org#16164) ggml : fix uninitialized is_on_grid in quantize_row_iq3_xxs_impl (ggml-org#15928) zdnn: refactor codebase + add docs (ggml-org#16178) codeowners : add @danbev to model-conversion example [no ci] (ggml-org#16190) devops: add s390x containers (ggml-org#15915) ggml-cpu : fix typo in gemm comments [no ci] (ggml-org#16189) feat: Add conversion support in GraniteHybrid for non-hybrid (all attn) (ggml-org#16177) clang-tidy : disable warning about performance enum size (ggml-org#16127) ggml : implement set_rows with i32 index (ggml-org#16159) codeowners : update + cleanup (ggml-org#16174) common : enable `--offline` mode without curl support (ggml-org#16137) webui : fix handling incomplete chunks (ggml-org#16107) embedding : fix typos in README (ggml-org#16171) common : remove unused local variables (ggml-org#16140) ggml : extend ggml_can_fuse to work with non-sequential nodes (ggml-org#16123) ggml : add ggml_op_is_empty (ggml-org#16122) codeowners : update ownership for @ngxson and @allozuar (ggml-org#16128) Vulkan: add conv_transpose_2d operation (ggml-org#16022) ...
No description provided.