Skip to content

Conversation

taronaeo
Copy link
Collaborator

This PR fixes the false positive build warnings for GCC 13.3 and later as seen in (#15925 (comment)) that have been raised due to GCC on s390x being more strict.

Raising this PR first to ensure that this update to miniaudio.h does not break any multimodal integrations.

Tracking: mackron/miniaudio#1048 #15925

Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
@taronaeo taronaeo requested a review from ggerganov as a code owner September 24, 2025 06:25
@CISC
Copy link
Collaborator

CISC commented Sep 24, 2025

@ggerganov So, I think @taronaeo has access to merge this, but how can one tell?

@ggerganov
Copy link
Member

There is no way to tell - Github UI does not seem to provide information about who has write access.

@taronaeo
Copy link
Collaborator Author

@ggerganov So, I think @taronaeo has access to merge this, but how can one tell?

Yep I have access to merge. But I'll hold this for another 24 hours just in-case @/ngxson or someone else maintaining the multimodal part of the codebase has any comments to add or found something broken with this vendor file update.

@taronaeo
Copy link
Collaborator Author

Ignoring CI / ggml-ci-x64-cpu-amx failure as feedbacked here: #16178 (comment)

  • CI / ggml-ci-mac-vulkan has failures with test-backend-ops, which I don't think is caused by this PR?
[SET_ROWS] NMSE = 0.000000174 > 0.000000100   SET_ROWS(type=q5_1,type_idx=i64,ne=[256,11,1,7],nr23=[2,3],r=7,v=0): FAIL
  • CI / macOS-latest-cmake-arm64 has failures with test-barrier where it timed out.
test 34
      Start 34: test-barrier

34: Test command: /Users/runner/work/llama.cpp/llama.cpp/build/bin/test-barrier
34: Working Directory: .
34: Test timeout computed to be: 900
34: graph-compute with
34:  n_threads: 4
34:    n_nodes: 2000
34:   n_rounds: 100
32/37 Test #34: test-barrier ......................***Timeout 900.02 sec

Will re-trigger these CIs again, except AMX, to check if it's an ephemeral problem

@ggerganov
Copy link
Member

None of these failures are related to the change here.

@taronaeo taronaeo merged commit b05a9d6 into ggml-org:master Sep 25, 2025
159 of 167 checks passed
pwilkin pushed a commit to pwilkin/llama.cpp that referenced this pull request Sep 25, 2025
* vendor: update miniaudio.h

Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>

* vendor: update miniaudio.h

Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>

---------

Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
struct pushed a commit to struct/llama.cpp that referenced this pull request Sep 26, 2025
* vendor: update miniaudio.h

Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>

* vendor: update miniaudio.h

Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>

---------

Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants