Skip to content

Setting the ftype argument of the script as optional #1629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Setting the ftype argument of the script as optional #1629

wants to merge 1 commit into from

Conversation

jpodivin
Copy link
Contributor

@jpodivin jpodivin commented May 28, 2023 •
edited
Loading

The 'ftype' positional argument of the convert-pth-to-ggml.py script has a default value set. However positional arguments still act as mandatory, unless they are set to accept zero values.

This change will allow the script to execute even when user doesn't supply the ftype manually.

#1628

@jpodivin
Setting the ftype argument of the script as optional
36758b1 
The 'ftype' positional argument of the convert-pth-to-ggml.py script
has default value set. However, as a positional argument it is set
to required unless number of values expected is set to accept zero values.

Signed-off-by: Jiri Podivin <jpodivin@gmail.com>
@SlyEcho
Copy link
Collaborator

SlyEcho commented May 29, 2023

I don't think we should improve this script, it is only for backwards compatibility after convert.py was created.

@jpodivin
Copy link
Contributor Author

I don't think we should improve this script, it is only for backwards compatibility after convert.py was created.

In that case I would suggest an alternative approach. The script is called by containers using the tools.sh script.
If it is effectively deprecated, it would be prudent to replace that call with one to convert.py. https://github.com/ggerganov/llama.cpp/blob/master/.devops/tools.sh#L14

I would close this PR and later submit a new one with the replacement. After I'm sure it's actually working as intended. I can't do that right away.

@SlyEcho
Copy link
Collaborator

SlyEcho commented May 29, 2023

Yes, tools.sh should be updated.

@jpodivin
Copy link
Contributor Author

Yes, tools.sh should be updated.

I'm closing the PR and I'll submit a patch for tools.sh instead.

@jpodivin jpodivin closed this May 29, 2023
@jpodivin jpodivin deleted the convert-pth-to-ggml-argfix branch May 29, 2023 10:04
@Bearsaerker Bearsaerker mentioned this pull request Mar 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpodivin @SlyEcho