vulkan: make ggml_vk_default_dispatcher support older vulkan headers #16345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Vulkan
|
I looked back in the vulkan-hpp commit history, I think this change was made between header versions 281 and 282. |
Acly
reviewed
Sep 30, 2025
|
I've tested on my Raspberry Pi 5 running Pi OS 12 (based on Debian 12), applying this PR/patch, and recompiling llama.cpp, I am able to build it successfully again. Before I was getting the errors shown in #16311. |
Nope it happened between 300 and 301. See this diff: KhronosGroup/Vulkan-Headers@cbcad3c#diff-a83f956c7aeb2b6dee7ffa2f249c0d98a2cfad6e157fe8438e372a5267afaeff |
netrunnereve
force-pushed
the
dispatchloaderdynamic
branch
from
fc68e43 to
ee10ca3
Compare
jeffbolznv
approved these changes
Sep 30, 2025
0cc4m
approved these changes
Oct 1, 2025
Merged
yael-works
pushed a commit
to yael-works/llama.cpp
that referenced
this pull request
Oct 15, 2025
…gml-org#16345) * make ggml_vk_default_dispatcher support older vulkan headers * simpilfy with using
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically Vulkan headers 1.3.301 and newer contain
vk::detail::DispatchLoaderDynamicand the older ones havevk::DispatchLoaderDynamicinstead.