Disable NUMA-specific chunking for high-core-count HPC systems #16882
+8
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables the NUMA-specific chunking logic in ggml when running on large-core systems.
Background: The previous implementation applied special chunking for NUMA machines:
The intention was to optimize parallelization across threads by re-chunking work for NUMA nodes, based on findings in PR #6915
However, empirical results on high-core-count NUMA machines indicate that this optimization can hurt performance, especially when the number of threads increases.
Changes Proposed
Observations:
This PR proposes an improvement intended to spark discussion toward a more holistic, hardware-agnostic solution. It also highlights that the current algorithm may not suit all hardware architectures.
cc: @shivammonaka