Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scripts to support cross-platform execution #285

Closed
wants to merge 1 commit into from
Closed

Fix scripts to support cross-platform execution #285

wants to merge 1 commit into from

Conversation

maye76
Copy link

@maye76 maye76 commented Mar 19, 2023

This change modifies the quantize.sh script so that it can run properly on different platforms (including the Windows platform in the WSL environment).

@sw sw mentioned this pull request Mar 19, 2023
@ggerganov
Copy link
Member

ggerganov commented Mar 19, 2023

Should we make it python script instead of BASH?

@sw
Copy link
Contributor

sw commented Mar 19, 2023

Should we make it python script instead of BASH?

@SuajCarrot did the work in #222. I have tested that on Linux but not on Windows.

@tomsnunes
Copy link

Should we make it python script instead of BASH?

@SuajCarrot did the work in #222. I have tested that on Linux but not on Windows.

I have successfully tested it on Windows.

@ggerganov
Copy link
Member

Ok, let's go with #222 then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants