Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: make sanitizers linking #468

Closed
wants to merge 2 commits into from

Conversation

Green-Sky
Copy link
Collaborator

clearly no one tested this.

@Green-Sky
Copy link
Collaborator Author

Green-Sky commented Mar 25, 2023

@ggerganov 😏 enabling asan and detecting memory leaks (see ci)

@ggerganov
Copy link
Member

Maybe add separate sanitize CI like in whisper.cpp:

https://github.com/ggerganov/whisper.cpp/blob/8e361d90d7948de3ecae73e10878040044836800/.github/workflows/build.yml#L92-L116

@Green-Sky Green-Sky mentioned this pull request Mar 25, 2023
@anzz1
Copy link
Contributor

anzz1 commented Mar 25, 2023

@Green-Sky should i port these changes to the format in #497

@Green-Sky
Copy link
Collaborator Author

@anzz1 sure, go ahead. will have some time later to check.

anzz1 added a commit that referenced this pull request Mar 25, 2023
@anzz1
Copy link
Contributor

anzz1 commented Mar 25, 2023

@anzz1 sure, go ahead. will have some time later to check.

Done.

@Green-Sky
Copy link
Collaborator Author

merge into #497

@Green-Sky Green-Sky closed this Mar 25, 2023
anzz1 added a commit that referenced this pull request Mar 25, 2023
* CMake: Add AVX512 option

* CI: Add AVX/AVX512 builds (Windows)
(AVX512 tests can only be run when the worker happens to support it, building works anyway)

* CMake: Fix sanitizer linkage ( merged #468 )

* CI: Add sanitizer builds (Ubuntu)

* CI: Fix release tagging
(change @zendesk/action-create-release to @anzz1/action-create-release until upstream PR Added commitish as input zendesk/action-create-release#32 is merged)
@Green-Sky Green-Sky deleted the fix_cmake_san branch May 1, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants