with logits_all == true, use to the last logits vector #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolved in 03f7e33. |
Deadsg
pushed a commit
to Deadsg/llama.cpp
that referenced
this pull request
Dec 19, 2023
Added info to set ENV variables in PowerShell
AAbushady
pushed a commit
to AAbushady/llama.cpp
that referenced
this pull request
Jan 27, 2024
* Update colab.ipynb * Update colab.ipynb * Update colab.ipynb * Update colab.ipynb * Update colab.ipynb * Update colab.ipynb * Update colab.ipynb * Update colab.ipynb * Update colab.ipynb * Update colab.ipynb * Update colab.ipynb * Update colab.ipynb * Update colab.ipynb * Update colab.ipynb * Update colab.ipynb * Update colab.ipynb * Update colab.ipynb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affects
llama_sample_top_p_top_kandparams.ignore_eosmode inmain.cpp.Alternatively the sampler could take an additional argument indicating the position to sample in the batch.
As of now, I haven't come across any code path that hit this issue (beside my changes in #477).