-
Notifications
You must be signed in to change notification settings - Fork 14k
nix: init images #5056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nix: init images #5056
Conversation
f7994ab to
d460baf
Compare
|
@SomeoneSerge Is this PR still relevant, or we can close it? |
|
@ggerganov sorry I got distracted and forgot to finish this. I'd still like to merge this, I just need to allocate an evening for polishing EDIT: I skimmed through the changes and I can't recall what was it I wanted to add before merging |
d460baf to
768c339
Compare
philiptaron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Built locally on x86_64-linux with nix build github:someoneserge/llama.cpp/feat/nix/images#llamaPackages.{docker,docker-min,sif,llama-cpp} and it's fast and effective.
|
I intend to merge when CI completes. @ggerganov, perhaps you could turn on the ability to automerge after CI in the repo settings? Maybe the repo rules aren't set up to make that effective, though, since it says I can merge right now, so CI might not be a blocker. |
|
Yes, merging can be done anytime if at least 1 approval is provided. But for now I'll keep the auto-merge disabled |
Exposes a few attributes demonstrating how to build [singularity](https://docs.sylabs.io/guides/latest/user-guide/)/[apptainer](https://apptainer.org/) and Docker images re-using llama.cpp's Nix expression. Built locally on `x86_64-linux` with `nix build github:someoneserge/llama.cpp/feat/nix/images#llamaPackages.{docker,docker-min,sif,llama-cpp}` and it's fast and effective.
Exposes a few attributes demonstrating how to build singularity/apptainer and docker images re-using
llama.cpp's Nix expression(cherry-picks from #4917, needs rebasing later)