Use getopts for example scripts #664
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @prusnak |
ggerganov
requested changes
Apr 2, 2023
|
|
||
| while getopts "m:u:a:t:p:g:" opt; do | ||
| case $opt in | ||
| m) MODEL="--model $OPTARG";; |
There was a problem hiding this comment.
Any reason for not doing it like this for consistency:
Suggested change
| m) MODEL="--model $OPTARG";; | |
| m) MODEL="$OPTARG";; |
|
|
||
| ./main $MODEL --color \ | ||
| ./bin/main $MODEL --color \ |
There was a problem hiding this comment.
The example scripts are meant to be run from the source root, so this has to remain ./main
|
Feel free to reopen if the suggestions are resolved, closing to remove clutter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors two Bash scripts to use proper argument parsing and fixes some bugs.
The first script (reason-act.sh) used an if-statement to check for the presence of a command-line argument and set a variable accordingly. This has been replaced with
getoptsto parse the-moption and its argument. The script now uses quotes to prevent word splitting and globbing, and has a shebang at the beginning.The second script (chat-13B.sh) used several environment variables to specify various settings, and some of them had default values. This has been changed to use
getoptsto parse command-line options and their arguments. The default values have been moved to the variable definitions. Quotes have been added to variables to prevent word splitting and globbing. An error message has been added for invalid options.