Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change sys.exit(1) to raise SystemExit(1) #698

Closed
wants to merge 1 commit into from
Closed

Change sys.exit(1) to raise SystemExit(1) #698

wants to merge 1 commit into from

Conversation

mrcichon
Copy link

@mrcichon mrcichon commented Apr 2, 2023

Pedantic change; no need for importing sys if all we do is sys.exit(1)

@prusnak
Copy link
Collaborator

prusnak commented Apr 2, 2023

I don't think this is worth the change, using sys.exit() is so much more standard than raise SystemExit and sooner or later you're going to reintroduce import sys in the script anyway for some other reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants