Add Accelerate/BLAS when using Swift #765
Merged
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a10y
changed the title
|
@j-f1 as the original author of the Package file curious for your thoughts :) |
j-f1
requested changes
Apr 4, 2023
Co-authored-by: Jed Fox <git@jedfox.com>
|
Done! Confirmed test passes with the change |
j-f1
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
This repo and the community are amazing, props to the maintainers :)
I am playing around with the added Swift bindings for Mac/iOS and I noticed that BLAS didn't appear to be enabled at runtime with the default
Package.swiftfile even when I explicitly added theAccelerateframework on my target, looks like b/c some preprocessor directives weren't make their way to ggml.Before:
After: