Skip to content

cmake should link openblas with -lopenblas #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Apr 8, 2023
Merged

cmake should link openblas with -lopenblas #839

merged 1 commit into from Apr 8, 2023

Conversation

ghost
Copy link

@ghost ghost commented Apr 7, 2023

Currently if you build with cmake and LLAMA_OPENBLAS=ON it does not link the OpenBlas library properly and the build fails. This add OpenBlas linking to cmake like how it's done in the Makefile LDFLAGS (below).

ifdef LLAMA_OPENBLAS
    CFLAGS  += -DGGML_USE_OPENBLAS -I/usr/local/include/openblas
    LDFLAGS += -lopenblas

@sw sw merged commit f2d1c47 into ggml-org:master Apr 8, 2023
@sw
Copy link
Contributor

sw commented Apr 8, 2023

Thanks. I can confirm the link failure and that this fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant