nix: rely on propagatedBuild{Inputs,Outputs} for cuda #8772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
nix
Listing individual outputs no longer necessary to reduce the runtime closure size after NixOS/nixpkgs#323056
SomeoneSerge
force-pushed
the
cuda-propagatedBuildInputs
branch
from
d755dba to
5a618f0
Compare
philiptaron
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Here's how I tried to find out closure sizes.
$ nix derivation show github:someoneserge/llama.cpp/cuda-propagatedBuildInputs#cuda | jq -r keys[]
/nix/store/vxnjq87z41h3ckilplmgbr7waqf530dl-llama-cpp-cuda-0.0.0.drv
$ nix-build /nix/store/vxnjq87z41h3ckilplmgbr7waqf530dl-llama-cpp-cuda-0.0.0.drv
...
$ nix path-info --closure-size --human-readable /nix/store/vxnjq87z41h3ckilplmgbr7waqf530dl-llama-cpp-cuda-0.0.0.drv^*
/nix/store/mvw7b379xpx31c9hf60ypygv5jpmc9dd-llama-cpp-cuda-0.0.0 1.0 GiB
So the size for the new version is ~1.0 GiB.
$ nix derivation show github:ggerganov/llama.cpp#cuda | jq -r keys[]
/nix/store/hh7x8cpmdjwj18bgh5qim5kvigpcvvdg-llama-cpp-cuda-0.0.0.drv
$ nix-build /nix/store/hh7x8cpmdjwj18bgh5qim5kvigpcvvdg-llama-cpp-cuda-0.0.0.drv
...
$ nix path-info --closure-size --human-readable /nix/store/hh7x8cpmdjwj18bgh5qim5kvigpcvvdg-llama-cpp-cuda-0.0.0.drv^*
/nix/store/6b1ag2jh7zl5dj0q4a4f6ks4zhx634ih-llama-cpp-cuda-0.0.0 1.1 GiB
According to this method, the new version is slightly smaller than the old, and everything still builds.
Accepted. ✅
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Aug 2, 2024
Listing individual outputs no longer necessary to reduce the runtime closure size after NixOS/nixpkgs#323056.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Verify the closure sizes haven't increased
I have read the contributing guidelines
Self-reported review complexity: