Add commands to interactive mode. #924
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for everything in params during rumtime.
|
Factor out this in a separate helper function and maybe put it behind a cmd arg flag |
|
@ggerganov I refactored to a function. |
j-f1
reviewed
Apr 13, 2023
examples/main/main.cpp
Outdated
| @@ -47,6 +47,53 @@ void sigint_handler(int signo) { | |||
| } | |||
| #endif | |||
|
|
|||
| void command(std::string buffer, gpt_params params, const int n_ctx ) { | |||
| // check buffer's first 3 chars equal '???' to enter command mode. | |||
| if (strncmp(buffer.c_str(), "???", 3) == 0 && buffer.length() > 3) { | |||
There was a problem hiding this comment.
Nit: please negate this condition and do an easy return so the function body doesn't have to be indented again:
Suggested change
| if (strncmp(buffer.c_str(), "???", 3) == 0 && buffer.length() > 3) { | |
| if (buffer.length() <= 3 || strncmp(buffer.c_str(), "???", 3) != 0) return; |
|
It would print random gibberish after entering a command. This is now fixed. I also cleaned up the code and changed a few prints to make more sense. This should be ready for review now. |
pull down new code
merge command line code
merge new code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought of this while working on something else.
Its super useful. You can change startup params on the fly using the command:
??? CMD paramwhere CMD is a command line argument, and params is the number following each argument.
In my testing so far changing values has changed the models output.
This should enable users to test different params in run time against a single prompt. We can now fine tune the params using a single prompt. Simply copy and paste the prompt over and over after changing the param and compare the output.