Use <ESC> key instead of <C-o> in accepting changes #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After using a few days, ggml-org#38 seems to be solved with this commit. The previous <C-o> way might rely on the UI response time.
|
Are you using NeoVim? I just tested with classic Vim and this change breaks the accept - it does not work. For example, pressing tab simply inputs a tab instead of accepting. |
I tested on NeoVim v0.11.4 and Vim 9.1 (included patches: 1-1841). Both are working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After testing a few days, #38 seems to be solved with this commit. The previous way might rely on the UI response time.