Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webpack build #1

Merged
merged 7 commits into from
Dec 7, 2021
Merged

Conversation

maikthomas
Copy link

@maikthomas maikthomas commented Dec 7, 2021

Add webpack to build sframe and bundle the worker inline.
I have created a test repo to demonstrate that this build can be installed via npm (via github) and that the example works:
https://github.com/maikthomas/sframe-import-webpack

Copy link
Owner

@ggoldens ggoldens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ggoldens ggoldens merged commit f942f09 into ggoldens:master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants