Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor task names #27

Closed
ghale opened this issue May 3, 2014 · 5 comments
Closed

Refactor task names #27

ghale opened this issue May 3, 2014 · 5 comments

Comments

@ghale
Copy link
Owner

ghale commented May 3, 2014

Since we support both jobs and views now, it makes sense to refactor the task names from "updateJenkinsJobs" to "updateJenkinsItems", "dumpJenkinsJobs" to "dumpJenkinsItems", etc.

@zeeke
Copy link
Contributor

zeeke commented May 3, 2014

+1

@sgoings
Copy link
Contributor

sgoings commented May 9, 2014

It also might be neat if you could leverage task rules to mess with items:

jenkins {
  servers {
    production { ... }
    test { ... }
    development { ...}
  }
}

Would enable one to run:

  • updateJenkinsItemsProduction
  • updateJenkinsItemsTest
  • updateJenkinsItemsDevelopment

This is a bit nicer to use sometimes than passing in properties to the job (and also shows up in --tasks output). Additionally, I could type the short form even more efficiently: ./gradlew uJIP vs ./gradlew uJIT vs ./gradlew uJID

Thoughts?

@ghale
Copy link
Owner Author

ghale commented May 9, 2014

That's a pretty good idea. I've done something similar with some plugins we use internally and it works really well. Then we'd just make updateJenkinsItems an aggregator task for all of the updateJenkinsItems* tasks. I like it.

ghale added a commit that referenced this issue May 19, 2014
@ghale
Copy link
Owner Author

ghale commented May 19, 2014

This turned into a non-trivial refactor of the task plumbing, but the end result is much cleaner. Needs some further testing/scrutiny, but core use cases should be covered.

@ghale
Copy link
Owner Author

ghale commented May 26, 2014

This is in v1.1.0.

@ghale ghale closed this as completed May 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants