-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure gherkinrc file to place rules in rules #248
base: master
Are you sure you want to change the base?
Restructure gherkinrc file to place rules in rules #248
Conversation
The changes look very good and thank for taking the time to do them. I think we should break compatibility and I can prep that with a major version bump. This will ensure that people don't install by accident the new version and it will prevent us from having to support multiple code paths which depend on the existence of a specific string in the keys of a user defined json file. This also gives flexibility to add more configuration to the file in the future and it's in par with what .eslinrc does |
c401c05
to
e325781
Compare
e325781
to
734f78c
Compare
Pull Request Test Coverage Report for Build 6413256063
💛 - Coveralls |
This change will allow for future changes to the gherkinlint configuration file for configuration of non-rule based features.
734f78c
to
c45889f
Compare
This change will allow for future changes to the gherkinlint
configuration file for configuration of non-rule based features.
This relates to your suggestion to add an additionalRules configuration directive.
Let me know what you think. I haven’t added any backwards-compatibility.