Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize Input (GSI-900) #14

Merged
merged 6 commits into from
Jul 22, 2024
Merged

Conversation

TheByronHimes
Copy link
Member

This update will run html.escape on all the values made available to the templates. With the example template, only the name and body are injected, but the other values are accessible to the person writing the config. Therefore, all in the payload dict are escaped.

Bumps version to 1.1.2

Also refactored the _construct_email method because the plaintext and html part constructions were redundant.

@coveralls
Copy link

coveralls commented Jul 22, 2024

Pull Request Test Coverage Report for Build 10038752897

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.4%) to 83.122%

Totals Coverage Status
Change from base Build 9952718860: 3.4%
Covered Lines: 197
Relevant Lines: 237

💛 - Coveralls

Copy link
Member

@mephenor mephenor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, just needs some smaller improvements

src/ns/core/notifier.py Outdated Show resolved Hide resolved
src/ns/core/notifier.py Outdated Show resolved Hide resolved
@TheByronHimes TheByronHimes merged commit fe65bd4 into main Jul 22, 2024
8 checks passed
@TheByronHimes TheByronHimes deleted the feature/sanitize_input_GSI-900 branch July 22, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants