Added support for large SPI flashes when restoring. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a device reset upon restore success. Updated README.md to reflect the changes.
kbeckmann
reviewed
Aug 21, 2023
openocd/stm32h7x_spiflash.cfg
Outdated
| # OCTOSPI1: memory-mapped 1-line read mode with 3-byte addresses | ||
| mww 0x52005100 0x01002101 ;# OCTOSPI_CCR: DMODE=0x1, ABMODE=0x0, ADSIZE=0x2, ADMODE=0x1, ISIZE=0x0, IMODE=0x1 | ||
|
|
||
| if { [env LARGE_FLASH] == 0 } { |
There was a problem hiding this comment.
Is this branch taken when LARGE_FLASH is unset, i.e. not set to "0"? Just want to be sure :)
There was a problem hiding this comment.
That would be my understanding yes. But I could flip it to make it more clear and explicit and be inline with the check in ./5_restore.sh. I'll do that just so the check align.
There was a problem hiding this comment.
I checked and double checked.
- [env LARGE_FLASH] actually ONLY checks if LARGE_FLASH is present in the environment variables
I have updated the code to both test for presents and for the value.
So you did actually dodge a bullet here.
Thanks for the review.
|
Thanks for the PR! Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a device reset upon restore success.
Updated README.md to reflect the changes.
The changes makes it possible to restore the device to a stock configuration after the SPI flash has been replaced with a larger size (that uses 4 byte addresses).