Add plugin option for global filters #14
Conversation
…ers=[semi-colon separated message patterns]
| @@ -0,0 +1,10 @@ | |||
| package testdata | |||
|
|
|||
| object globallyFiltered { | |||
There was a problem hiding this comment.
Please write this test so that there's one warning suppressed and one similar warning unsuppressed (e.g. one that doesn't match the regex). This way we test if silencer only suppresses exactly what we want it to suppress and we also avoid changing the multiple files compilation test.
| private lazy val reporter = | ||
| new SuppressingReporter(global.reporter, globalFilters) | ||
|
|
||
| override def processOptions( |
There was a problem hiding this comment.
Please use single-line formatting and remove procedure syntax, e.g.
override def processOptions(options: List[STring], error: String => Unit): Unit = {
| import scala.reflect.internal.util.{Position, SourceFile} | ||
| import scala.tools.nsc.reporters.Reporter | ||
|
|
||
| class SuppressingReporter(original: Reporter) extends Reporter { | ||
| class SuppressingReporter( |
There was a problem hiding this comment.
Please keep the parameters in a single line.
There was a problem hiding this comment.
I don't have such limit in silencer project, currently I have formatting enforced by IntelliJ and it limits lines to 120 columns which for me is more sensible. You can also move extends Reporter { to next line but leave parameters in a single line.
|
Good job, thanks a lot! |
|
looks useful — would like to try it out in a release |
|
should this PR have included README changes? |
|
I'll try to update README and do a release until the end of this week. |
Support minimal global filter as plugin option
-P:silencer:globalFilters=[semi-colon separated message patterns]See example