Skip to content

Update to Angular 14 required due to deprecated dependencies (core-js) #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Adam-Pond opened this issue Jul 30, 2022 · 3 comments · Fixed by #35
Closed

Update to Angular 14 required due to deprecated dependencies (core-js) #33

Adam-Pond opened this issue Jul 30, 2022 · 3 comments · Fixed by #35

Comments

@Adam-Pond
Copy link

What are the chances someone could publish an updated version?

warning angular-markdown-editor > core-js@2.6.12: core-js@<3.23.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues. Please, upgrade your dependencies to the actual version of core-js.

@ghiscoding
Copy link
Owner

If you want to help and provide Pull Requests to update necessary stuff, I'd be happy to cut a release afterward. I just don't have the bandwidth to work on this at the moment.

@ghiscoding
Copy link
Owner

ghiscoding commented Jul 30, 2022

looking at the package.json and I guess that core-js and vinyl-paths can simply be moved from dependencies to devDependencies or simply be removed and that would fix the security issues. It would be nice to get a contribution if you're up to it

"dependencies": {
"bootstrap": "^3.4.0",
"bootstrap-markdown": "toopay/bootstrap-markdown",
"core-js": "^2.5.1",
"font-awesome": "^4.7.0",
"jquery": ">=3.2.1",
"vinyl-paths": "^2.1.0"
},
"devDependencies": {

@ghiscoding
Copy link
Owner

the change is done, see new v3.0.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants