feat!: default .js as ESM, CJS to .cjs & build target ES2021
#171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this breaking PR should make the lib fully support ESM ready following Vite's [Deprecate CJS Node API](https://vitejs.dev/guide/migration.html#migration-from-v4) recommendations - bump build target from ES2018 to ES2021 - drop `.js` ouputs and now only build as `.cjs` and `.mjs` to be fully ESM ready while still supporting hybrid mode (CJS/ESM) - move legacy `<script>` loading to `browser/multiple-select.{cjs,mjs}` - move all locales from `dist/` to `dist/locales/multiple-select-all-locales.{cjs,mjs}`
🎭 Playwright Summary - Success 🎉Playwright Report
Running 69 tests using 2 workers |
ghiscoding
changed the title
.js instead build as .cjs and .mjs and target ES2021.js move to .cjs and .mjs builds + target ES2021
ghiscoding
changed the title
.js move to .cjs and .mjs builds + target ES2021.js as ESM and move to .cjs for CJS and build target ES2021
ghiscoding
changed the title
.js as ESM and move to .cjs for CJS and build target ES2021.js as ESM, CJS to .cjs & build target ES2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.jsfile extension by following Vite's Deprecate CJS Node API recommendations while staying hybrid (CJS/ESM).jsextension to default as ESM and provide.cjsextension for users who want CJS and keep supporting hybrid mode (CJS/ESM)<script>loading fromdist/root todist/browser/multiple-select.{js,cjs}("browser" is meant for legacy script loading)<script type="module" src="https://cdn.jsdelivr.net/npm/multiple-select-vanilla@1.0.0/dist/browser/multiple-select.js"></script><script src="https://cdn.jsdelivr.net/npm/multiple-select-vanilla@1.0.0/dist/browser/multiple-select.cjs"></script>dist/todist/locales/multiple-select-all-locales.{js,cjs}