-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(common)!: migrate from Flatpickr to Vanilla-Calendar #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
ghiscoding
commented
Apr 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #1466 +/- ##
=======================================
+ Coverage 99.8% 99.8% +0.1%
=======================================
Files 199 199
Lines 21763 21766 +3
Branches 7264 7249 -15
=======================================
+ Hits 21699 21702 +3
Misses 58 58
Partials 6 6 ☔ View full report in Codecov by Sentry. |
ghiscoding
changed the title
feat!: migrate from Flatpickr to Vanilla-Calendar
feat(common)!: migrate from Flatpickr to Vanilla-Calendar
Apr 15, 2024
- also fix an issue found with date range picker closing before too early with just 1 date clicked
Alright, I think this is ready to be merged and move to next phase :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vanilla-calendar-picker
TODOs
Build Size Comparison
NOTE actually it turns out that after the Vanilla-Calendar migration, the build is larger not smaller (as seen in the demo build) and the reason was because the CSS file wasn't properly loaded which made it looks like it was smaller but in fact is larger.