feat(styling)!: delete "bare" Themes but keep "lite" & add to Bootstrap #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #1493 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 197 197
Lines 21652 21652
Branches 7207 7207
=====================================
Hits 21586 21586
+ Misses 66 60 -6
- Partials 0 6 +6 ☔ View full report in Codecov by Sentry. |
|
After testing the change in Angular-Slickgrid, I pushed a couple of small commits and I don't see any problems with this new implementation, so I'm gonna go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's quick details about file size comparison with/without "lite" for each theme. I think Material is slightly larger because it also includes the the Roboto font family
Also tested in Angular-Slickgrid, all is good after migrating all
.fato.mdiicons. I also tested the "lite" edition and it works correctly too (sort, grouping, ... icons are showing but not the menu ones)