fix(styling): couple of small alignment issues when using flex #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- when using flex on `.slick-cell` like in Example 7, a couple of small issues came up mostly with flex alignment - also fix some flex issues directly in ms-select lib and update it here to get fixes, also remove some now duplicate CSS - we should use `column-gap` instead of `gap` to only change the gap horizontally but not vertically
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #1496 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 197 197
Lines 21652 21653 +1
Branches 7207 6939 -268
=======================================
+ Hits 21586 21587 +1
Misses 66 66 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.slick-celllike in Example 7, a couple of small issues came up mostly with flex alignmentcolumn-gapinstead ofgapto only change the gap horizontally but not vertically