Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a bit more SlickGrid tests and add some Prettier ignore #1784

Merged
merged 6 commits into from
Dec 21, 2024

Conversation

ghiscoding
Copy link
Owner

No description provided.

Copy link

stackblitz bot commented Dec 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 95.70957% with 26 lines in your changes missing coverage. Please review.

Project coverage is 99.8%. Comparing base (f2c273b) to head (f59461a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
packages/common/src/core/slickGrid.ts 91.7% 26 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1784     +/-   ##
========================================
+ Coverage    99.7%   99.8%   +0.2%     
========================================
  Files         187     187             
  Lines       35055   34035   -1020     
  Branches    10271   10107    -164     
========================================
- Hits        34926   33947    -979     
+ Misses        129      88     -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit e63d012 into master Dec 21, 2024
7 checks passed
@ghiscoding ghiscoding deleted the chore/prettier-test-coverage branch December 21, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant